Fix the wrong removal of first linker arg in Windows. Small refactor of handling of linker response file. #5010
+28
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qouteall
force-pushed
the
fix_windows_linker_arg
branch
from
27ad378 to
e1fc1fd
Compare
qouteall
force-pushed
the
fix_windows_linker_arg
branch
from
e1fc1fd to
08535b4
Compare
qouteall
force-pushed
the
fix_windows_linker_arg
branch
from
08535b4 to
65f4624
Compare
… file no longer include first program name argument. Small refactor of handling of linker response file.
qouteall
force-pushed
the
fix_windows_linker_arg
branch
from
65f4624 to
dd840d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5008
I tested that web platform hotpatch works in windows (msvc toolchain). I also tested that web platform hotpatch in wsl (gnu toolchain) and desktop platform in windows keeps working.